#2393 - Add ButtonSubmit.vue for 'Send message' button
#2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
group-income
|
||||||||||||||||||||||||||||
| Project |
group-income
|
| Branch Review |
sebin/task/#2393-same-multiple-dms-issue
|
| Run status |
|
| Run duration | 08m 59s |
| Commit |
|
| Committer | Sebin Song |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
10
|
Skipped
|
0
|
Passing
|
111
|
| View all changes introduced in this branch ↗︎ | |
taoeffect
reviewed
Oct 30, 2024
| @@ -178,6 +181,9 @@ export default ({ | |||
| } | |||
| this.toggleTooltip() | |||
| } | |||
| }, | |||
| beforeDestroy () { | |||
| console.log('!@# destroyed!!') | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2393
Apparently, the tooltip is dismissed immediately after the 'Send message' button when
this.createDirectMessage(this.contractID)triggered by it is a series of async operation.group-income/frontend/views/components/ProfileCard.vue
Line 171 in 83f11f1
So replaced the button with
ButtonSubmit.vueas the visual indicator so that it gets dismissed after the DM is created.Hope it sounds good and let me know if there is addition al thing needed along with this.