Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper validator functions #2353

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Use proper validator functions #2353

merged 1 commit into from
Sep 16, 2024

Conversation

corrideat
Copy link
Member

Fix #2352

@corrideat corrideat requested a review from taoeffect September 16, 2024 16:57
@corrideat corrideat force-pushed the 2352-broken-validation-in-gicontractsgroupupdatesettings branch from f936890 to e6c23a8 Compare September 16, 2024 16:58
taoeffect
taoeffect requested changes Sep 16, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @corrideat ! Minor issue found:

frontend/model/contracts/group.js Show resolved Hide resolved
@corrideat corrideat force-pushed the 2352-broken-validation-in-gicontractsgroupupdatesettings branch from e6c23a8 to fc6a458 Compare September 16, 2024 17:20
taoeffect
taoeffect approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cypress Cypress
Copy link

cypress bot commented Sep 16, 2024

group-income    Run #3139

Run Properties:  status check passed Passed #3139  •  git commit a2e6574ed5 ℹ️: Merge fc6a458ac76bf7e3997f1d38236e824ee767199a into 245f0c0f781531f0caea44ae394b...
Project group-income
Branch Review 2352-broken-validation-in-gicontractsgroupupdatesettings
Run status status check passed Passed #3139
Run duration 09m 24s
Commit git commit a2e6574ed5 ℹ️: Merge fc6a458ac76bf7e3997f1d38236e824ee767199a into 245f0c0f781531f0caea44ae394b...
Committer Ricardo Iván Vieitez Parra
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 10
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 111
View all changes introduced in this branch ↗︎

@taoeffect taoeffect merged commit fa8ebf8 into master Sep 16, 2024
4 checks passed
@taoeffect taoeffect deleted the 2352-broken-validation-in-gicontractsgroupupdatesettings branch September 16, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken validators
2 participants
@corrideat @taoeffect