Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1818 Cropped off menu in chat #1821

Merged
merged 5 commits into from
Jan 28, 2024
Merged

#1818 Cropped off menu in chat #1821

merged 5 commits into from
Jan 28, 2024

Conversation

SebinSong
Copy link
Collaborator

closes #1818

@SebinSong SebinSong self-assigned this Jan 25, 2024
taoeffect
taoeffect requested changes Jan 25, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this doesn't pass the linter (see grunt dev).

Also, I wasn't able to really test this because I don't know how to reproduce it in e2e-protocol... in what situation did it fail before?

Base automatically changed from e2e-protocol to master January 25, 2024 19:27
@cypress Cypress
Copy link

cypress bot commented Jan 28, 2024

Passing run #1833 ↗︎

0 110 8 0 Flakiness 0

Details:

Merge eee57e0 into c0c5f84...
Project: group-income Commit: b012a61b3d ℹ️
Status: Passed Duration: 18:31 💡
Started: Jan 28, 2024 5:09 AM Ended: Jan 28, 2024 5:28 AM

Review all test suite changes for PR #1821 ↗︎

@SebinSong
Copy link
Collaborator Author

SebinSong commented Jan 28, 2024 •
edited
Loading

@taoeffect Fixed that linter error. and here is how you reproduce the issue. (you have to reduce the screen width to the tablet range)

chat.cropped.off.mp4

taoeffect
taoeffect approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@taoeffect taoeffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@taoeffect taoeffect merged commit fc4cc7c into master Jan 28, 2024
5 checks passed
@taoeffect taoeffect deleted the sebin/task/#1818-cropped-off-menu-in-chat branch January 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taoeffect taoeffect taoeffect approved these changes

Assignees

@SebinSong SebinSong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Edit message' menu in the chatroom is cropped off sometimes
2 participants
@SebinSong @taoeffect