Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications displayed when someone sends you a DM while you have the DM open #2392

Closed
taoeffect opened this issue Oct 23, 2024 · 0 comments · Fixed by #2394
Closed

Notifications displayed when someone sends you a DM while you have the DM open #2392

taoeffect opened this issue Oct 23, 2024 · 0 comments · Fixed by #2394

Comments

@taoeffect
Copy link
Member

Problem

So when using the ssh -R 80:localhost:8000 [email protected] tunnel with grunt dev to test on mobile, I opened up a DM with myself from Desktop to Mobile, and any time I sent a DM to the phone while I had the phone open and showing the DM page, I would get a notification and the phone would buzz:

tmp-1729712704525

Solution

We already have code not to make a sound when the DM is active. We should likewise not post a notification in this instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants