Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to get contractID of person who sent a GIMessage (innerSigningContractID() function) #2125

Closed
taoeffect opened this issue Jun 27, 2024 · 0 comments
Assignees
Labels
Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Priority:High

Comments

@taoeffect
Copy link
Member

taoeffect commented Jun 27, 2024

Problem

In PR #2046 there is the desire to display who sent a GIMessage that resulted in an error:

Screenshot 2024-06-27 at 10 49 28 AM

It seems like there's no simple way to get this information from a GIMessage.

Solution

Implement innerSigningContractID() on GIMessage that returns this info if available as a string, otherwise null.

Update the code here (see screenshot above if link doesn't work) to restore the contractID information for that notification so that we can know what user sent the failing message.

@taoeffect taoeffect added Kind:Enhancement Improvements, new features, performance upgrades, etc. Priority:High Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind:Core Anything that changes or affects the fundamental core data structures & design of the application. Kind:Enhancement Improvements, new features, performance upgrades, etc. Priority:High
Projects
None yet
Development

No branches or pull requests

2 participants