-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OILS_COMP_UI #2244
add OILS_COMP_UI #2244
Conversation
05e7e2e
to
31801a3
Compare
OK I think this is a good change We should document it in:
and I would mention that it is only consulted at startup (and then we can also document OILS_MAX_COMP_LINES in the same place) It is possible to write a test for this? I guess it is hard to test because it changes the TAB behavior only ... I suppose the only way we have of testing that is I guess we are going to run into the same issue with OILS_MAX_COMP_LINES - it is hard to test hmmmm |
Pushed some docs. Let me know if I should tweak the wording |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
doc/ref/chap-special-var.md
Outdated
### OILS_COMP_UI | ||
|
||
Set which completion UI to use. Set to `minimal` for a UI that approximates the | ||
default behavior of readline. Set to `nice` for a UI with a fancy pager and a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say "GNU readline" because some people might not know what "readline" is
I think it will nicer to read with a bulleted list, like
minimal
- ...nice
- ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
Great thanks! I pushed a ( I am trying to untangle the confusion of global vars in shell ... which ones are from ENV and which ones aren't? There are a bunch of quirks around PWD, PS1, etc. ) |
This will be more user-friendly than the existing command-line arg, since people can set it in their init files.