Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interactive tests that match other shells (e.g. Ctrl-C is exit code 130) #1077

Closed
andychu opened this issue Jan 21, 2022 · 2 comments
Closed

Add interactive tests that match other shells (e.g. Ctrl-C is exit code 130) #1077

andychu opened this issue Jan 21, 2022 · 2 comments
Labels
devtools pending-release signal-handling

Comments

@andychu
Copy link
Contributor

andychu commented Jan 21, 2022

We need a cross between test/interactive and spec tests. They will compare against other shells interactively
andychu pushed a commit that referenced this issue Jan 25, 2022
[test/interactive] Run interactive tests against bash too.
3f9c1da 
They are now closer to the style of spec tests.  This addresses #1077,
and paves the way for testing many other bug fixes (all the SIGWINCH,
wait, read, trap stuff).

I factored common code out of test/sh_spec.py into test/spec_lib.py.  We
should probably reuse the report table too.  This will show what tests
aren't running in bash and OSH.
andychu pushed a commit that referenced this issue Jan 26, 2022
[test/interactive] Print a table of results.
2009f8f 
Support selecting tests with --range and so forth.

Mark some tests skipped.  Now it's clear that #467 was incompletely
fixed, since the exit code isn't 130.  Ditto for the wait builtin, which
was an earlier bug.

This is part of #1077.
andychu pushed a commit that referenced this issue Jan 26, 2022
[test/interactive] Implement FAIL status
481f653 
- A bunch of refactoring.
- Document a test matrix.

This is more work on #1077.
@andychu
Copy link
Contributor Author

andychu commented Jan 26, 2022

Dug up #292 while looking at unifying all these manual tests

This is sort of a pattern

@andychu
Copy link
Contributor Author

andychu commented Jan 30, 2022

Done in 0.9.7: https://www.oilshell.org/blog/2022/01/notes-themes.html

@andychu andychu closed this as completed Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devtools pending-release signal-handling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andychu