Skip to content
This repository has been archived by the owner on Dec 2, 2023. It is now read-only.

Fixed webhook on backend #37

Merged
merged 1 commit into from
Feb 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/resolver/submission/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { SubmissionSetFieldMutation } from './submission.set.field.mutation'
import { SubmissionStartMutation } from './submission.start.mutation'
import { SubmissionStatisticQuery } from './submission.statistic.query'
import { SubmissionStatisticResolver } from './submission.statistic.resolver'
import { SubmissionFinishMutation } from './submission.finish.mutation'

export const submissionResolvers = [
SubmissionFieldResolver,
Expand All @@ -15,6 +16,7 @@ export const submissionResolvers = [
SubmissionQuery,
SubmissionResolver,
SubmissionSetFieldMutation,
SubmissionFinishMutation,
SubmissionStartMutation,
SubmissionStatisticQuery,
SubmissionStatisticResolver,
Expand Down
34 changes: 34 additions & 0 deletions src/resolver/submission/submission.finish.mutation.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
import { Injectable } from '@nestjs/common'
import { Args, Context, ID, Mutation } from '@nestjs/graphql'
import { User } from '../../decorator/user.decorator'
import { SubmissionProgressModel } from '../../dto/submission/submission.progress.model'
import { SubmissionSetFieldInput } from '../../dto/submission/submission.set.field.input'
import { SubmissionEntity } from '../../entity/submission.entity'
import { UserEntity } from '../../entity/user.entity'
import { SubmissionService } from '../../service/submission/submission.service'
import { SubmissionSetFieldService } from '../../service/submission/submission.set.field.service'
import { ContextCache } from '../context.cache'

@Injectable()
export class SubmissionFinishMutation {
constructor(
private readonly submissionService: SubmissionService,
private readonly setFieldService: SubmissionSetFieldService,
) {
}

@Mutation(() => SubmissionProgressModel)
async submissionFinish(
@User() user: UserEntity,
@Args({ name: 'submission', type: () => ID }) id: string,
@Context('cache') cache: ContextCache,
): Promise<SubmissionProgressModel> {
const submission = await this.submissionService.findById(id)

await this.setFieldService.finishSubmission(submission)

cache.add(cache.getCacheKey(SubmissionEntity.name, submission.id), submission)

return new SubmissionProgressModel(submission)
}
}
5 changes: 3 additions & 2 deletions src/service/submission/submission.hook.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ export class SubmissionHookService {
return {
field: submissionField.field.id,
slug: submissionField.field.slug || null,
value: submissionField.field.value,
}
default_value: submissionField.field.value,
content: submissionField.content,
}
}),
}

Expand Down
33 changes: 19 additions & 14 deletions src/service/submission/submission.set.field.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,28 @@ export class SubmissionSetFieldService {
}

if (submission.percentageComplete === 1) {
this.webHook.process(submission).catch(e => {
this.logger.error({
submission: submission.id,
form: submission.formId,
error: serializeError(e),
}, 'failed to send webhooks')
})
this.notifications.process(submission).catch(e => {
this.logger.error({
submission: submission.id,
form: submission.formId,
error: serializeError(e),
}, 'failed to send notifications')
})
this.finishSubmission(submission)
}
}

async finishSubmission(submission: SubmissionEntity) {
submission.percentageComplete = 1
this.webHook.process(submission).catch(e => {
this.logger.error({
submission: submission.id,
form: submission.formId,
error: serializeError(e),
}, 'failed to send webhooks')
})
this.notifications.process(submission).catch(e => {
this.logger.error({
submission: submission.id,
form: submission.formId,
error: serializeError(e),
}, 'failed to send notifications')
})
}

private parseData(
field: SubmissionFieldEntity,
data: string
Expand Down