Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stderr redirection compatible with Fish 3.0. #6

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

bobthecow
Copy link
Member

Fish has deprecated ^ as a shortcut for stderr redirection in 3.0. Replace it with the more
compatible 2>.

See oh-my-fish/oh-my-fish#609 and oh-my-fish/oh-my-fish#618

@BarbzYHOOL
Copy link
Contributor

and it works in 2.7?

@bobthecow
Copy link
Member Author

Yep! The standard stderr redirects have always worked (or at least for as long as I can remember). Fish additionally had this ^ shortcut, and that is now deprecated and only usable behind a feature flag.

@BarbzYHOOL
Copy link
Contributor

Ok, why you don't merge it? and my PR too

@bobthecow
Copy link
Member Author

Because it's @derekstavis's repo :)

@bobthecow bobthecow requested a review from derekstavis January 7, 2019 16:23
@BarbzYHOOL
Copy link
Contributor

it's oh-my-fish's

else why you'd be member, that's for this purpose :P

@derekstavis
Copy link
Member

Thanks for the fixes!!

@derekstavis derekstavis merged commit 5919656 into oh-my-fish:master Jan 7, 2019
@bobthecow bobthecow deleted the fish-three branch January 7, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants