Add support for absolute URLs in useRedirect

Closes marmelab#6464
ogustavo-pereira · Nov 23, 2021 · 7ec6d8e · 7ec6d8e
1 parent 55253db
commit 7ec6d8e
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 4 deletions.
diff --git a/packages/ra-core/src/sideEffect/useRedirect.spec.tsx b/packages/ra-core/src/sideEffect/useRedirect.spec.tsx
@@ -47,4 +47,18 @@ describe('useRedirect', () => {
             state: { _scrollToTop: true, bar: 'baz' },
         });
     });
+    it('should support absolute URLs', () => {
+        const oldLocation = window.location;
+        delete window.location;
+        // @ts-ignore
+        window.location = { href: '' };
+        const history = createMemoryHistory();
+        renderWithRedux(
+            <Router history={history}>
+                <Redirect redirectTo="https://google.com" />
+            </Router>
+        );
+        expect(window.location.href).toBe('https://google.com');
+        window.location = oldLocation;
+    });
 });
diff --git a/packages/ra-core/src/sideEffect/useRedirect.ts b/packages/ra-core/src/sideEffect/useRedirect.ts
@@ -57,10 +57,22 @@ const useRedirect = () => {
                 return;
             }
 
-            history.push({
-                ...parsePath(resolveRedirectTo(redirectTo, basePath, id, data)),
-                state: { _scrollToTop: true, ...state },
-            });
+            if (
+                typeof redirectTo === 'string' &&
+                redirectTo.startsWith('http') &&
+                window
+            ) {
+                // redirection to an absolute url
+                // history doesn't handle that case, so we handle it by hand
+                window.location.href = redirectTo;
+            } else {
+                history.push({
+                    ...parsePath(
+                        resolveRedirectTo(redirectTo, basePath, id, data)
+                    ),
+                    state: { _scrollToTop: true, ...state },
+                });
+            }
         },
         [dispatch, history]
     );