fabtests/pytest/common.py: skip neuron to neuron tests on single node #8428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because both client and server utilize all Neuron cores, they cannot request -D neuron on the same node. Thus skip those tests. Signed-off-by: Wenduo Wang <[email protected]>
wzamazon
reviewed
Jan 20, 2023
| @@ -292,6 +292,9 @@ def prepare_base_command(self, command_type, executable, | |||
| pytest.skip("no cuda device") | |||
| elif host_memory_type == "neuron" and not has_neuron(host_ip): | |||
| pytest.skip("no neuron device") | |||
| elif (client_memory_type == server_memory_type == "neuron") and ( | |||
| self._cmdline_args.server_id == self._cmdline_args.client_id): | |||
| pytest.skip("Neuron to Neuron tests require 2 nodes") | |||
There was a problem hiding this comment.
only "neuron to neuron" has this limitation?
There was a problem hiding this comment.
Right. The failure mode is that we cannot run 2 processes with -D neuron on the same node. The 1st process will occupy all Neuron cores, and the 2nd process will fail because there is no Neuron cores available.
wzamazon
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because both client and server utilize all Neuron cores, they cannot request -D neuron on the same node. Thus skip those tests.
Signed-off-by: Wenduo Wang [email protected]