Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rrd_rpncalc: Quiet gcc warning by copying one extra character. #1243

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

hramrach
Copy link
Contributor

@hramrach hramrach commented Jan 6, 2024

gcc warns that strncpy truncates the copied string. Above the size allocated includes space for terminating zero. Include it in the copy.

gcc warns that strncpy truncates the copied string. Above the size
allocated includes space for terminating zero. Include it in the copy.

Signed-off-by: Michal Suchanek <[email protected]>
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b76e3c5) 51.02% compared to head (31e1fee) 51.02%.

Files Patch % Lines
src/rrd_rpncalc.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1243   +/-   ##
=======================================
  Coverage   51.02%   51.02%           
=======================================
  Files          45       45           
  Lines       18214    18214           
=======================================
  Hits         9293     9293           
  Misses       8921     8921           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oetiker oetiker merged commit f713618 into oetiker:master Jan 7, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants