Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to book metadata editing #166

Merged
merged 7 commits into from
Feb 20, 2014
Merged

updates to book metadata editing #166

merged 7 commits into from
Feb 20, 2014

Conversation

TomWoodward
Copy link
Member

No description provided.

@kathi-fletcher
Copy link
Member

Testing checklist:

Opf file

  • Don't want a new book to be "based on anything". <meta property="schema:isBasedOnUrl">http://github.com/oerpub/empty-book/content/empty-book.opf</meta>. If the repo the book is in is forked from somewhere, then this field should be set to the original repo.
  • ID is empty: <dc:identifier id="uid"/> This should be the URL to the repo. We have this as the .opf file right now.
  • When creating a new shelf, we need to the metadata editing widget to come up.

-Nav file

  • Meta tags need closing. <meta itemprop="inLanguage" content="en">

@kathi-fletcher
Copy link
Member

OK -- Three of the four things are improved. I never get the metadata to pop up when I create a new shelf, either from the login page or from "change shelf". I am going to make a separate issue for it and we can come back after module metadata and video.

Also, I realized while testing that forking really doesn't do right by metadata, but that is going to be a whole nother set of details to get right. I will get them written up, but doubt we will try to tackle them.

The id is fine for now. It isn't a URL as originally requested.

kathi-fletcher added a commit that referenced this pull request Feb 20, 2014
updates to book metadata editing
@kathi-fletcher kathi-fletcher merged commit a8c2587 into master Feb 20, 2014
@kathi-fletcher kathi-fletcher deleted the book-metadata branch February 20, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants