Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem snuck in after I fixed the double-body problem some time ago. By using the innerHTML of the body instead of serializing the body, I ended up with a xmlns on every top level element inside the body.
When you hit enter in Aloha, it makes a copy of whatever element it's in. It also copies all the attributes. It didn't like copying xmlns, hence the error message.
This fixes the problem using somewhat of a sledgehammer approach. It parses the body/head out using regex. Normally that's a bad idea for html, but here we use fresh html from XMLSerializer, so it should be safe.