Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use atc repo for shared code #115

Closed
wants to merge 12 commits into from
Closed

Use atc repo for shared code #115

wants to merge 12 commits into from

Conversation

philschatz
Copy link
Member

Step towards making a common shared repo gh-book and atc

Depends on #107

Commits start with "include atc project as bower component" 6d23921

@TomWoodward
Copy link
Member

im assuming that the many files you deleted are replaced in the atc repo? that makes the atc repo a dependency of gh-book even outside the context of connexions right? i thought we were aiming for the reverse relationship, not sure how i feel about that. @kathi-fletcher and thoughts?

@philschatz
Copy link
Member Author

My thoughts on splitting up the repos:

  1. make gh-book depend on atc
  2. create common repo and make atc depend on common (delete ~5 files; they would remain in atc)
  3. change gh-book to depend on common (1 line change)
  4. Prefix each repo so requirejs config can be shorter

@TomWoodward
Copy link
Member

i'm cool with making gh-book depend on atc as an interim step but as a permanent architecture it bothers me since gh-book may be embedded in other environments

@izak
Copy link

izak commented Nov 21, 2013

👍

@kathi-fletcher
Copy link
Member

I am going to close this PR since we have another one on the same topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants