-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use atc repo for shared code #115
Conversation
EpubContainer for gh-book and WorkspaceRoot for atc
this causes problems when filteredCollection tries to keep its collection in sync
it should at the very least send @ as an argument
Conflicts: scripts/gh-book/app.coffee
Conflicts: scripts/gh-book/app.coffee
Conflicts: scripts/views/layouts/workspace/sidebar.coffee
im assuming that the many files you deleted are replaced in the atc repo? that makes the atc repo a dependency of gh-book even outside the context of connexions right? i thought we were aiming for the reverse relationship, not sure how i feel about that. @kathi-fletcher and thoughts? |
My thoughts on splitting up the repos:
|
i'm cool with making gh-book depend on atc as an interim step but as a permanent architecture it bothers me since gh-book may be embedded in other environments |
👍 |
I am going to close this PR since we have another one on the same topic. |
Step towards making a common shared repo
gh-book
andatc
Depends on #107
Commits start with "include atc project as bower component" 6d23921