Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] real_estate: added real estate module #327

Draft
wants to merge 2 commits into
base: 18.0
Choose a base branch
from

Conversation

nmak-odoo
Copy link

@nmak-odoo nmak-odoo commented Feb 6, 2025

Created the real estate module for technical training

@robodoo
Copy link

robodoo commented Feb 6, 2025

Pull request status dashboard

@nmak-odoo nmak-odoo changed the title test [ADD] real_estate: added real estate module Feb 6, 2025
Day 1 :
Chapter 2  : Created Folder Structure for Real-estate module
Chapter 3  : Created estate_properties model with all the basic fields
[IMP] real-estate: security , ui and search filters

Day 2 :
Chapter 4: Understood Data files(CSV) and gave access-rights
Chapter 5: Understood Data files(XML) and Implemented actions , menus and fields
Chapter 6: Understood Basic views and Implemented List , Form and Search filters
Day 3 - Chapter 7:

Added Many2one relationship for property types (dropdown selection).
Added Many2many relationship for property tags (below name field).
Partially implemented One2many relationship for property offers.
Copy link

@maad-odoo maad-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋,

Please the PR message and the commit messages as well.
Maintain consistency in the code.

Thank You :)

@@ -0,0 +1 @@
hello

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is not needed. Please remove it

{
"name": "Real Estate",
"author": "nmak",
"website": "https://www.odoo.com/apps/estate",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a good idea to URL that is not legit

@@ -0,0 +1 @@
from . import models

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"name": "Real Estate",
"author": "nmak",
"website": "https://www.odoo.com/apps/estate",
"category": "tutorials/estate",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"category": "tutorials/estate",
'category': 'Tutorials/estate',

"installable": True,
"application": True,
"auto_install": False,
"license": "LGPL-3",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smae

Suggested change
"license": "LGPL-3",
'license': 'LGPL-3',

Same as above

Comment on lines +3 to +4
class PropertyTag(models.Model):
_name = "estate.property.tag"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class PropertyTag(models.Model):
_name = "estate.property.tag"
class EstatePropertyTag(models.Model):
_name = "estate.property.tag"


class PropertyTag(models.Model):
_name = "estate.property.tag"
_description = "tags involved in real estate"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adapt the description message, it not up to the mark

Comment on lines +1 to +3
from odoo import models,fields

class PropertyTag(models.Model):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo import models,fields
class PropertyTag(models.Model):
from odoo import models,fields
class PropertyTag(models.Model):

We usually leave 2 empty line before class definition

Comment on lines +1 to +3
from odoo import models, fields

class EstatePropertyType(models.Model):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo import models, fields
class EstatePropertyType(models.Model):
from odoo import models, fields
class EstatePropertyType(models.Model):

2 empty line before class definition

<field name="arch" type="xml">
<form string="Property">
<sheet>
<h1 class="">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1 class="">
<h1>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants