-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] real_estate: added real estate module #327
base: 18.0
Are you sure you want to change the base?
Conversation
7a0aca0
to
03625d0
Compare
Day 1 : Chapter 2 : Created Folder Structure for Real-estate module Chapter 3 : Created estate_properties model with all the basic fields [IMP] real-estate: security , ui and search filters Day 2 : Chapter 4: Understood Data files(CSV) and gave access-rights Chapter 5: Understood Data files(XML) and Implemented actions , menus and fields Chapter 6: Understood Basic views and Implemented List , Form and Search filters
03625d0
to
876288a
Compare
8676a02
to
f7b3476
Compare
Day 3 - Chapter 7: Added Many2one relationship for property types (dropdown selection). Added Many2many relationship for property tags (below name field). Partially implemented One2many relationship for property offers.
f7b3476
to
fb43c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋,
Please the PR message and the commit messages as well.
Maintain consistency in the code.
Thank You :)
@@ -0,0 +1 @@ | |||
hello |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is not needed. Please remove it
{ | ||
"name": "Real Estate", | ||
"author": "nmak", | ||
"website": "https://www.odoo.com/apps/estate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a good idea to URL that is not legit
@@ -0,0 +1 @@ | |||
from . import models |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"name": "Real Estate", | ||
"author": "nmak", | ||
"website": "https://www.odoo.com/apps/estate", | ||
"category": "tutorials/estate", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"category": "tutorials/estate", | |
'category': 'Tutorials/estate', |
"installable": True, | ||
"application": True, | ||
"auto_install": False, | ||
"license": "LGPL-3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smae
"license": "LGPL-3", | |
'license': 'LGPL-3', |
Same as above
class PropertyTag(models.Model): | ||
_name = "estate.property.tag" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class PropertyTag(models.Model): | |
_name = "estate.property.tag" | |
class EstatePropertyTag(models.Model): | |
_name = "estate.property.tag" |
|
||
class PropertyTag(models.Model): | ||
_name = "estate.property.tag" | ||
_description = "tags involved in real estate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adapt the description message, it not up to the mark
from odoo import models,fields | ||
|
||
class PropertyTag(models.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from odoo import models,fields | |
class PropertyTag(models.Model): | |
from odoo import models,fields | |
class PropertyTag(models.Model): |
We usually leave 2 empty line before class definition
from odoo import models, fields | ||
|
||
class EstatePropertyType(models.Model): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from odoo import models, fields | |
class EstatePropertyType(models.Model): | |
from odoo import models, fields | |
class EstatePropertyType(models.Model): |
2 empty line before class definition
<field name="arch" type="xml"> | ||
<form string="Property"> | ||
<sheet> | ||
<h1 class=""> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<h1 class=""> | |
<h1> |
Created the real estate module for technical training