[ADD] estate: create a new module for real estate management #326

aych-odoo · 2025-02-06T06:34:17Z

Created a new Real Estate module for managing real estate properties as part of the training.

Properties can be added with a specified property type and assigned multiple tags.
Properties have a salesperson and a buyer assigned to them.
Offers can be made on properties, and the best price is automatically computed from the submitted offers.

robodoo · 2025-02-06T06:34:20Z

Day 1: Chapter 2: created directory structure along with manifest file for estate module Chapter 3: created estate_properties model Day 2: Chapter 4: created ir.model.access.csv to enable CRUD operation on property Chapter 5: created basic action and menu for estate property Chapter 6: created basic views for estate property i.e. list, form, search Chapter 7: created property type model and defined Many2one relation.

maad-odoo

Hello 👋,

Added few comments and suggestions please have a look into it.
PR message is missing and commit messages can be improved.

Thank You :)

estate/__init__.py

estate/__manifest__.py

estate/models/__init__.py

estate/models/estate_property.py

estate/models/estate_property_offer.py

estate/views/estate_property_menu_views.xml

estate/views/estate_property_views.xml

Added the estate.property.offer model with One2many relation to estate.property, allowing offers to be managed from the property form view. Introduced the estate.property.tag model with a Many2many relation, enabling tag creation via Settings -> Property Tags and assignment through the Many2many widget. Added computed fields: total_area (sum of garden_area and living_area) and best_price (highest offer price). Implemented an onchange handler for the garden field to set or reset related fields automatically.

Day 4: Added 'sold' and 'cancel' actions to the property form view, allowing properties to be marked as sold or canceled with proper validations. Implemented logic to automatically set the selling price and buyer, when an offer is accepted. Added SQL constraints to ensure all price-related fields remain positive, with selling_price required to be greater than 90% of expected_price. Enforced unique constraints to prevent duplicate property tags and types. Added default sorting across all estate models, with sequence-based sorting for property types. Enhanced the property, offers list view with color coding and adjusted button visibility based on the property's status.

Day 5: Added an Offers stat button in the property types view, which displays all offers made on properties under the selected type. Implemented restrictions on property deletion, allowing deletion only when the property's state is New or Cancelled. Extended res.users model with property_ids, enabling properties to be viewed in the user profile. Developed the estate_account module to facilitate invoicing, ensuring an invoice is generated when a property is sold, even if the user lacks access to the invoicing module. Created a Kanban view for properties, grouped by property type. Created Manager and Agent user groups with distinct access rights, along with a security rule limiting Agents to viewing only the properties they have created.

… property Day 6: Restricted property visibility for Agents to only those belonging to their company by implementing a multi-company rule. Updated access control to ensure that only users with the Manager role can view the settings menu in the estate module. Added demo data for the property, property_type, and property_offer models to facilitate testing and development. Integrated a chatter feature in the property model to track changes in the property name.

maad-odoo

Hii 👋

Here is an another quick review

maad-odoo · 2025-02-10T18:14:34Z

estate/models/estate_property.py

+class User(models.Model):
+    _inherit = "res.users"
+
+    property_ids = fields.One2many(
+        string="Properties",
+        comodel_name="estate.property",
+        inverse_name="salesperson_id",
+        domain="[('state', 'in', ['new', 'offer_received'])]"
+    )


Add this in a different file

maad-odoo · 2025-02-10T18:15:38Z

estate/models/estate_property_offer.py

+            record.validity = (record.date_deadline - record.create_date.date()).days
+
+    def action_accept_offer(self):
+        if any([x.status == "accepted" for x in self.property_id.offer_ids]):


Suggested change

if any([x.status == "accepted" for x in self.property_id.offer_ids]):

if any([property.status == "accepted" for property in self.property_id.offer_ids]):

maad-odoo · 2025-02-10T18:16:18Z

estate/models/estate_property.py

+        copy=False
+    )
+    active = fields.Boolean(default=True)
+


Unnecessary diff

maad-odoo · 2025-02-10T18:16:42Z

estate/models/estate_property.py

+
+    total_area = fields.Integer(string="Total Area (sqm)", compute="_compute_total_area")
+    best_price = fields.Float(string="Best Price", compute="_compute_best_price")
+


Unnecessary diff

maad-odoo · 2025-02-10T18:17:37Z

estate/models/estate_property.py

+    def action_sell_property(self):
+        if self.state == "cancelled":
+            raise UserError("Cancelled property cannot be sold")
+


Unnecessary diff

maad-odoo · 2025-02-11T17:10:30Z

estate/views/estate_property_views.xml

+                <field name="name" width="200px" />
+                <field name="property_type_id" width="150px" />
+                <field name="postcode" width="150px" />
+                <field name="tag_ids" widget="many2many_tags" width="200px" />


Avoid using hard-coded style rules as this might not work for every screen size or for every case.

maad-odoo · 2025-02-11T17:12:26Z

estate/views/estate_property_views.xml

+                        <div> Expected Price: <field name="expected_price" />
+                        </div>
+                        <div t-if="record.state.raw_value == 'offer_received'"> Best Offer: <field
+                                name="best_price" />
+                        </div>
+                        <div t-if="record.state.raw_value == 'offer_accepted'"> Selling Price: <field
+                                name="selling_price" />
+                        </div>


Suggested change

<div> Expected Price: <field name="expected_price" />

</div>

<div t-if="record.state.raw_value == 'offer_received'"> Best Offer: <field

name="best_price" />

</div>

<div t-if="record.state.raw_value == 'offer_accepted'"> Selling Price: <field

name="selling_price" />

</div>

<div>

Expected Price: <field name="expected_price" />

</div>

<div t-if="record.state.raw_value == 'offer_received'">

Best Offer: <field name="best_price" />

</div>

<div t-if="record.state.raw_value == 'offer_accepted'">

Selling Price: <field name="selling_price" />

</div>

Indentation

maad-odoo · 2025-02-11T17:13:47Z

estate/views/estate_property_views.xml

+                    <button name="action_sell_property" type="object" string="Sold"
+                        invisible="state in ['offer_accepted', 'sold', 'cancelled']" />


Suggested change

<button name="action_sell_property" type="object" string="Sold"

invisible="state in ['offer_accepted', 'sold', 'cancelled']" />

<button name="action_sell_property"

invisible="state in ['offer_accepted', 'sold', 'cancelled']"

type="object"

string="Sold"

/>

maad-odoo · 2025-02-11T17:14:55Z

estate/views/estate_property_views.xml

+                    <button name="action_sell_property" type="object" string="Sold"
+                        invisible="state in ['new', 'offer_received', 'sold', 'cancelled']"
+                        class="btn-primary" />
+                    <!-- Cancel button-->
+                    <button name="action_cancel_property" type="object" string="Cancel"
+                        invisible="state in ['sold', 'cancelled']" />


Refer to above comment ☝️

maad-odoo · 2025-02-11T17:17:06Z

estate_account/models/estate_property.py

+        if not self.buyer_id.id:
+            raise UserError("Property without buyer cannot be sold")
+
+        self.env["estate.property"].check_access("write")


Put this in try.. expect block to avoid error

aych-odoo changed the title ~~test~~ [ADD] estate: new module added Feb 6, 2025

aych-odoo force-pushed the 18.0-training-aych branch from 635a8e6 to 30bce68 Compare February 6, 2025 06:43

aych-odoo force-pushed the 18.0-training-aych branch from 30bce68 to c80414f Compare February 6, 2025 08:53

aych-odoo mentioned this pull request Feb 6, 2025

[ADD] estate: added a new real estate module #315

Closed

maad-odoo reviewed Feb 6, 2025

View reviewed changes

aych-odoo force-pushed the 18.0-training-aych branch from f4bf858 to ae28070 Compare February 7, 2025 05:48

aych-odoo changed the title ~~[ADD] estate: new module added~~ [ADD] estate: create a new module which tracks properties Feb 7, 2025

aych-odoo changed the title ~~[ADD] estate: create a new module which tracks properties~~ [ADD] estate: create a new module for real estate management Feb 7, 2025

aych-odoo force-pushed the 18.0-training-aych branch from 200a5a9 to 5a94e27 Compare February 7, 2025 13:19

aych-odoo force-pushed the 18.0-training-aych branch from 5a94e27 to 8cf6b22 Compare February 7, 2025 13:25

aych-odoo added 2 commits February 10, 2025 18:58

maad-odoo reviewed Feb 11, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] estate: create a new module for real estate management #326

[ADD] estate: create a new module for real estate management #326

aych-odoo commented Feb 6, 2025 •

edited

Loading

robodoo commented Feb 6, 2025

maad-odoo left a comment

maad-odoo left a comment

maad-odoo Feb 10, 2025

maad-odoo Feb 10, 2025

maad-odoo Feb 10, 2025

maad-odoo Feb 10, 2025

maad-odoo Feb 10, 2025

maad-odoo Feb 11, 2025

maad-odoo Feb 11, 2025

maad-odoo Feb 11, 2025

maad-odoo Feb 11, 2025

maad-odoo Feb 11, 2025

	if any([x.status == "accepted" for x in self.property_id.offer_ids]):
	if any([property.status == "accepted" for property in self.property_id.offer_ids]):


		total_area = fields.Integer(string="Total Area (sqm)", compute="_compute_total_area")
		best_price = fields.Float(string="Best Price", compute="_compute_best_price")

		<button name="action_sell_property" type="object" string="Sold"
		invisible="state in ['offer_accepted', 'sold', 'cancelled']" />

[ADD] estate: create a new module for real estate management #326

Are you sure you want to change the base?

[ADD] estate: create a new module for real estate management #326

Conversation

aych-odoo commented Feb 6, 2025 • edited Loading

robodoo commented Feb 6, 2025

maad-odoo left a comment

Choose a reason for hiding this comment

maad-odoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aych-odoo commented Feb 6, 2025 •

edited

Loading