[ADD] created a new module, model definition,added security file,crea… #322
Conversation
…ted action and menuitems, created custom list view
|
|
There was a problem hiding this comment.
Hello @jodh-odoo ,
I've added some suggestions. Please have a look at them.
Please make sure to add a new line at the end of every file.
estate/models/estate_property.py
Outdated
| default="new", | ||
| selection=[('new', 'New'), ('offerreceived', 'Offer Received'), ('offeraccepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')] | ||
| ) | ||
| active=fields.Boolean(default=True) |
There was a problem hiding this comment.
No new line at EOF
Check other occurences also.
There was a problem hiding this comment.
checked all the occurences and add a new line at EOF.
estate/__manifest__.py
Outdated
| @@ -0,0 +1,13 @@ | |||
| { | |||
| 'name':'Real Estate', | |||
| 'version':'0.0.0', | |||
There was a problem hiding this comment.
| 'version':'0.0.0', | |
| 'version':'1.0', |
please add correct version for module.
There was a problem hiding this comment.
Check the proper sequencing for fields in manifest file.
There was a problem hiding this comment.
Checked the proper sequencing and done changes accordingly.
estate/models/estate_property.py
Outdated
| name=fields.Char(required=True,default="Unknown") | ||
| description=fields.Text() | ||
| postcode=fields.Char() | ||
| date_availability=fields.Date(copy=False,default=fields.Date.today()+timedelta(days=+90)) |
There was a problem hiding this comment.
| date_availability=fields.Date(copy=False,default=fields.Date.today()+timedelta(days=+90)) | |
| date_availability = fields.Date(copy=False, default=fields.Date.today() + timedelta(days=90)) |
Please ensure the entire module follows coding guidelines by adding spaces wherever necessary.
Could you explain the purpose of "copy", "required", "readonly" parameters?
There was a problem hiding this comment.
copy is used to make sure that while duplicating a record the field where copy is used does not gets copied,
required is used to make the field not null, and read only parameter prevents the alteration of the field.
estate/models/estate_property.py
Outdated
| _description="test description" | ||
|
|
||
|
|
||
| name=fields.Char(required=True,default="Unknown") |
There was a problem hiding this comment.
| name=fields.Char(required=True,default="Unknown") | |
| name = fields.Char(required=True, default="Unknown") |
General comment to keep in mind from next time:
Please ensure the entire module follows coding guidelines by adding spaces wherever necessary.
There was a problem hiding this comment.
ensured the coding guidelines are followed according to your suggestion.
There was a problem hiding this comment.
Why there is need of new file for adding views?
Can't we add the views in its appropriate file (estate_property_views.xml)?
There was a problem hiding this comment.
added the views in their appropriate files.
| <field name="res_model">estate.property</field> | ||
| <field name="view_mode">list,form</field> | ||
| </record> | ||
|
|
There was a problem hiding this comment.
Why there is extra line here? Please remove the extra line.
…d cutom form view and search view, seperated files for menuitems and views,actions.
…ted action and menuitems, created custom list view