[ADD] Create module 'estate' and add models defination,security files… #320
Conversation
…, views and menus
|
|
There was a problem hiding this comment.
Hello @matd-odoo ,
Great work so far!
I've added some suggestions, please have a look at them.
Some general instructions:
- Please make sure to add a new line at the end of every file.
- Please ensure the entire module follows coding guidelines.
Thanks!
estate/__manifest__.py
Outdated
| # # data files containing optionally loaded demonstration data | ||
| # 'demo': [ | ||
| # 'demo/demo_data.xml', | ||
| # ], |
estate/__manifest__.py
Outdated
| # 'demo': [ | ||
| # 'demo/demo_data.xml', | ||
| # ], | ||
| } |
There was a problem hiding this comment.
| } | |
| } | |
No new line at EOF. Please check other occurrences as well.
| @@ -0,0 +1,38 @@ | |||
| from odoo import models, fields | |||
| from datetime import timedelta | |||
estate/models/estate_property.py
Outdated
|
|
||
| class EstateProperty(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Property warning!" |
There was a problem hiding this comment.
Description for model should be appropriate.
estate/models/estate_property.py
Outdated
| _name = "estate.property" | ||
| _description = "Property warning!" | ||
|
|
||
| name = fields.Char('Name', required=True, default='Unknown') |
There was a problem hiding this comment.
The string for the fields should be appropriate. Also what's the need of adding "default" parameter here?
There was a problem hiding this comment.
Suggested changes are done.
"default" parameter is use for by default set "Unknown" value in case if user not add name.
estate/models/estate_property.py
Outdated
| name = fields.Char('Name', required=True, default='Unknown') | ||
| description = fields.Text() | ||
| postcode = fields.Char('postcode', size=6) | ||
| date_avaliability = fields.Date('Available date', default=(fields.Date.today() + timedelta(days=90)).strftime('%Y-%m-%d'), copy=False) |
There was a problem hiding this comment.
Could you explain the purpose of "copy", "required", "readonly" parameters?
There was a problem hiding this comment.
"copy" parameter is use for copy fields value. by default "copy=True", if do not want to copy value then set "copy=False".
"required" parameter is use for fields value are mandatory.
"readonly" parameter is use for only read value of fields, can't change or update values.
estate/models/estate_property.py
Outdated
| ('cancelled', "Cancelled") | ||
| ] | ||
| ) | ||
| active = fields.Boolean(active=False) |
There was a problem hiding this comment.
What is the purpose of active field? and why you have passed 'False' in default?
There was a problem hiding this comment.
active field is use for filtering between currently active and non-active records, default=True use for non-active records.
estate/__manifest__.py
Outdated
| It's provide real estate module | ||
| """, | ||
| 'application': True, | ||
| # data files always loaded at installation |
There was a problem hiding this comment.
| # data files always loaded at installation |
is there any need for this comment here?
|
|
||
|
|
…custom list view, form view and search view.
…, views and menus