[FW][FIX] website_forum: redirect /forum/x/question/y simplify #156537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't try to keep extra params and co. Keep it simple... Else we should pop from request.params `forum` and `blog` keys because now they are converted as query param with the slug format: /forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,) X-original-commit: 5739602
|
|
|
This PR targets 16.0 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@JKE-be ci/style failed on this forward-port PR |
|
@JKE-be ci/security failed on this forward-port PR |
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2024
Don't try to keep extra params and co. Keep it simple... Else we should pop from request.params `forum` and `blog` keys because now they are converted as query param with the slug format: /forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,) closes #156537 X-original-commit: 5739602 Signed-off-by: Jérémy Kersten <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 9, 2024
Don't try to keep extra params and co. Keep it simple... Else we should pop from request.params `forum` and `blog` keys because now they are converted as query param with the slug format: /forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,) closes odoo/odoo#156537 X-original-commit: 5739602b29121eb8e91355a3f8f6f01528ddd6cb Signed-off-by: Jérémy Kersten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't try to keep extra params and co. Keep it simple...
Else we should pop from request.params
forumandblogkeys because now they are converted as query param with the slug format:/forum/help-1/question-1?forum=forum.forum(1,)&question=forum.post(1,)
Forward-Port-Of: #156458