Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: Fix matching rules with no partner #156291

Closed

Conversation

smetl
Copy link
Contributor

@smetl smetl commented Mar 4, 2024

The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 4, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 4, 2024
@smetl smetl requested review from a team and RicGR98 and removed request for a team March 4, 2024 14:12
Copy link
Contributor

@RicGR98 RicGR98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bugfix, thanks for the PR :)

The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689
@smetl smetl force-pushed the 16.0-fix-matching-rule-no-partner-las branch from 5fad80e to 7ac0fb9 Compare March 6, 2024 10:28
@smetl
Copy link
Contributor Author

smetl commented Mar 6, 2024

@RicGR98 done

@RicGR98 RicGR98 requested a review from oco-odoo March 6, 2024 10:32
Copy link
Contributor

@oco-odoo oco-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo pushed a commit that referenced this pull request Mar 6, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes #156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
@robodoo robodoo closed this Mar 6, 2024
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 9, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes odoo/odoo#156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 16, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes odoo/odoo#156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
@fw-bot fw-bot deleted the 16.0-fix-matching-rule-no-partner-las branch March 20, 2024 18:46
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 28, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes odoo/odoo#156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 28, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes odoo/odoo#156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino pushed a commit to numaes/numa-public-odoo that referenced this pull request Mar 28, 2024
The orm doesn't match monetary amounts using the related currency.
It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.

ticket_id: 3741689

closes odoo/odoo#156291

Signed-off-by: Olivier Colson (oco) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants