-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] account: Fix matching rules with no partner #156291
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicGR98
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting bugfix, thanks for the PR :)
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689
5fad80e
to
7ac0fb9
Compare
@RicGR98 done |
oco-odoo
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
robodoo
pushed a commit
that referenced
this pull request
Mar 6, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes #156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 9, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes odoo/odoo#156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 16, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes odoo/odoo#156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 28, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes odoo/odoo#156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 28, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes odoo/odoo#156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 28, 2024
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002. Let's match the amount using an sql query instead. ticket_id: 3741689 closes odoo/odoo#156291 Signed-off-by: Olivier Colson (oco) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The orm doesn't match monetary amounts using the related currency. It means, -208.73 != 208.730000000000002.
Let's match the amount using an sql query instead.
ticket_id: 3741689
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr