[FW][FIX] web_editor: prevent unexpected placeholder for editable area #146859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@utag-odoo @Goaman cherrypicking of pull request #140444 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
Previously, the code for adding placeholders checked if the content inside a block was either an empty string (`''`) or just a single `<br>` element. While this logic was intended to provide hints when blocks were empty, it had the unintended consequence of adding placeholders in situations where it wasn't necessary, such as when removing images from a section. To prevent unexpected placeholders, this commit refines the logic. It now adds a placeholder only when the content inside a block consists solely of a single `<br>` element, which is a more accurate indicator of an empty block. Additionally, this PR resolves an issue with the `drag and drop a building block here` functionality. Previously, when entering edit mode and clicking on `drag and drop a building block here,` it moved upward. after these changes, it remains fixed in its original position. task-3380599 X-original-commit: def1eee
utag-odoo
force-pushed
the
16.0-15.0-web_editor-remove_unexpected_placeholder-utag-5C7L-fw
branch
from
b3d3552 to
1e75289
Compare
|
@Goaman, We resolve the conflict. Can you please r+ |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 21, 2023
Previously, the code for adding placeholders checked if the content inside a block was either an empty string (`''`) or just a single `<br>` element. While this logic was intended to provide hints when blocks were empty, it had the unintended consequence of adding placeholders in situations where it wasn't necessary, such as when removing images from a section. To prevent unexpected placeholders, this commit refines the logic. It now adds a placeholder only when the content inside a block consists solely of a single `<br>` element, which is a more accurate indicator of an empty block. Additionally, this PR resolves an issue with the `drag and drop a building block here` functionality. Previously, when entering edit mode and clicking on `drag and drop a building block here,` it moved upward. after these changes, it remains fixed in its original position. task-3380599 closes #146859 X-original-commit: def1eee Signed-off-by: Nicolas Bayet (nby) <[email protected]> Signed-off-by: Antoine Guenet (age) <[email protected]>
This was referenced Dec 21, 2023
fw-bot
deleted the
16.0-15.0-web_editor-remove_unexpected_placeholder-utag-5C7L-fw
branch
luanjubica
pushed a commit
to luanjubica/odoo-code
that referenced
this pull request
Feb 14, 2024
Previously, the code for adding placeholders checked if the content inside a block was either an empty string (`''`) or just a single `<br>` element. While this logic was intended to provide hints when blocks were empty, it had the unintended consequence of adding placeholders in situations where it wasn't necessary, such as when removing images from a section. To prevent unexpected placeholders, this commit refines the logic. It now adds a placeholder only when the content inside a block consists solely of a single `<br>` element, which is a more accurate indicator of an empty block. Additionally, this PR resolves an issue with the `drag and drop a building block here` functionality. Previously, when entering edit mode and clicking on `drag and drop a building block here,` it moved upward. after these changes, it remains fixed in its original position. task-3380599 closes odoo#146859 X-original-commit: def1eee Signed-off-by: Nicolas Bayet (nby) <[email protected]> Signed-off-by: Antoine Guenet (age) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the code for adding placeholders checked if the content inside a block was either an empty string (
'') or just a single<br>element. While this logic was intended to provide hints when blocks were empty, it had the unintended consequence of adding placeholders in situations where it wasn't necessary, such as when removing images from a section.To prevent unexpected placeholders, this commit refines the logic. It now adds a placeholder only when the content inside a block consists solely of a single
<br>element, which is a more accurate indicator of an empty block.Additionally, this PR resolves an issue with the
drag and drop a building block herefunctionality. Previously, when entering edit mode and clicking ondrag and drop a building block here,it moved upward. After these changes, it remains fixed in its original position.task-3380599
Forward-Port-Of: #140444