[FW][FIX] web_editor: move snippets only across visible ones #146667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@bso-odoo @robinlej cherrypicking of pull request #145895 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
Before this commit if invisible elements are in the DOM (e.g. device-visibility restricted) the arrows to move snippets (columns, sections) did show up and behave as if the neighbour elements were visible. This commit hides arrows that would not visually move the snippet, and upon using the move arrow, it also moves the snippet beyond the first visible neighbour. Steps to reproduce as of 16.0: - Drop a "Columns" snippet. - Make the center column hidden on desktop. - Move the first column to the right. => It did not move and an arrow to move to the left was displayed. Steps to reproduce before 16.0: - Drop three snippets. - Make the second snippet conditionally visible. - Hide it using the eye icon in the "Invisible Elements" list. - Move the first block down. => It did not move and an arrow to move upwards was displayed. task-3584947 X-original-commit: d5a83de
bso-odoo
force-pushed
the
16.0-16.0-fix_device_move_column-bso-PLdy-fw
branch
from
af30947 to
caa0f2b
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 19, 2023
Before this commit if invisible elements are in the DOM (e.g. device-visibility restricted) the arrows to move snippets (columns, sections) did show up and behave as if the neighbour elements were visible. This commit hides arrows that would not visually move the snippet, and upon using the move arrow, it also moves the snippet beyond the first visible neighbour. Steps to reproduce as of 16.0: - Drop a "Columns" snippet. - Make the center column hidden on desktop. - Move the first column to the right. => It did not move and an arrow to move to the left was displayed. Steps to reproduce before 16.0: - Drop three snippets. - Make the second snippet conditionally visible. - Hide it using the eye icon in the "Invisible Elements" list. - Move the first block down. => It did not move and an arrow to move upwards was displayed. task-3584947 closes #146667 X-original-commit: d5a83de Signed-off-by: Robin Lejeune (role) <[email protected]>
This was referenced Dec 19, 2023
luanjubica
pushed a commit
to luanjubica/odoo-code
that referenced
this pull request
Feb 14, 2024
Before this commit if invisible elements are in the DOM (e.g. device-visibility restricted) the arrows to move snippets (columns, sections) did show up and behave as if the neighbour elements were visible. This commit hides arrows that would not visually move the snippet, and upon using the move arrow, it also moves the snippet beyond the first visible neighbour. Steps to reproduce as of 16.0: - Drop a "Columns" snippet. - Make the center column hidden on desktop. - Move the first column to the right. => It did not move and an arrow to move to the left was displayed. Steps to reproduce before 16.0: - Drop three snippets. - Make the second snippet conditionally visible. - Hide it using the eye icon in the "Invisible Elements" list. - Move the first block down. => It did not move and an arrow to move upwards was displayed. task-3584947 closes odoo#146667 X-original-commit: d5a83de Signed-off-by: Robin Lejeune (role) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit if invisible elements are in the DOM (e.g. device-visibility restricted) the arrows to move snippets (columns, sections) did show up and behave as if the neighbour elements were visible.
This commit hides arrows that would not visually move the snippet, and upon using the move arrow, it also moves the snippet beyond the first visible neighbour.
Steps to reproduce as of 16.0:
=> It did not move and an arrow to move to the left was displayed.
Steps to reproduce before 16.0:
=> It did not move and an arrow to move upwards was displayed.
task-3584947
Forward-Port-Of: #145895