[FIX] account, analytic: add analytic distribution, remove precompute #146549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
C3POdoo
requested review from
a team and
clbr-odoo
and removed request for
a team
h4818
approved these changes
Dec 20, 2023
h4818
reviewed
Dec 20, 2023
| @@ -2094,6 +2094,7 @@ def _prepare_exchange_difference_move_vals(self, amounts_list, company=None, exc | |||
| 'name': _('Currency exchange rate difference'), | |||
| 'debit': amount_residual if amount_residual > 0.0 else 0.0, | |||
| 'credit': -amount_residual if amount_residual < 0.0 else 0.0, | |||
| 'analytic_distribution': kwargs.get('exchange_analytic_distribution', False), | |||
There was a problem hiding this comment.
as discussed: False might prevent computations, so let's only add the key/value if the distribution is given
Related to odoo/enterprise#52648 we add the analytic distributino to the move vals for the exchange diff move. We also remove the precompute on the fields, manual backport of odoo@b9047fe opw-3603668
guva-odoo
force-pushed
the
16.0-opw-3603668-analytic-distribution-exchange-diff-line-reco-widget-guva
branch
from
26f197a to
ac26b63
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Dec 20, 2023
Related to odoo/enterprise#52648 we add the analytic distributino to the move vals for the exchange diff move. We also remove the precompute on the fields, manual backport of b9047fe opw-3603668 closes #146549 Related: odoo/enterprise#52648 Signed-off-by: Habib Ayob (ayh) <[email protected]>
This was referenced Dec 20, 2023
fw-bot
deleted the
16.0-opw-3603668-analytic-distribution-exchange-diff-line-reco-widget-guva
branch
luanjubica
pushed a commit
to luanjubica/odoo-code
that referenced
this pull request
Feb 14, 2024
Related to https://github.com/odoo/enterprise/pull/52648 we add the analytic distributino to the move vals for the exchange diff move. We also remove the precompute on the fields, manual backport of odoo@b9047fe opw-3603668 closes odoo#146549 Related: odoo/enterprise#52648 Signed-off-by: Habib Ayob (ayh) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/odoo/enterprise/pull/52648
we add the analytic distributino to the move vals for
the exchange diff move.
We also remove the precompute on the fields, manual backport
of b9047fe
opw-3603668