[FIX] point_of_sale,l10n_be_pos_sale: invoice settled order #139467

robinengels · 2023-10-23T12:08:52Z

Current behavior:
In Belgium when using a EU intracom tax, as we need to report those special sales to the government we need to create an invoice as we need to report the customer name, VAT number and the country where the goods are going to end up

Steps to reproduce:

Create an order with a product and a tax (0% EU M)
Settle the order in the PoS and pay it (no invoice)
Go to the accounting and check the EC Sales List report
There is an error shown in the report

opw-3514737

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2023-10-23T12:09:55Z

JulienAlardot

IMO we should force the creation of the invoice, else it would still break everything I will ask the POs for specifications

Please update the commit message to reflect the real issue

?In Belgium? when using a EU intracom tax, as we need to report those special sales to the government we need to create an invoice as we need to report the customer name, VAT number and the country where the goods are going to end up
Side-note: Another Belgian requirement in most cases is a document proving the goods will cross borders (if the goods aren't delivered but pick up directly)

JulienAlardot · 2023-10-25T08:15:38Z

addons/l10n_be_pos_sale/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-


Will only report it on this file but never adds new coding UTF-8, it's deprecated since python3.0 and Odoo stopped using python 2 for a while

JulienAlardot · 2023-10-25T08:42:57Z

addons/l10n_be_pos_sale/tests/test_l10n_be_pos_sale.py

+            'partner_id': self.partner_a.id,
+            'order_line': [(0, 0, {
+                'product_id': self.product_a.id,


Suggested change

'partner_id': self.partner_a.id,

'order_line': [(0, 0, {

'product_id': self.product_a.id,

'partner_id': self.partner_a.id,

'order_line': [Command.create({

'product_id': self.product_a.id,

tsb-odoo · 2023-10-26T15:37:27Z

To me, this PR is reacting to a symptom (namely highlighting problems with the EC Sales List because contextually, it was the concern that triggered this PR) but there are other aspects to reconsider in depth.

Wouldn't it be wiser to consider downpayments as invoices in any case ?
There is an open conversation about this (namely task 2786723) but also legal evolutions one should know. Does it really concern Belgium only ?
https://entreprendre.service-public.fr/vosdroits/F31412#:~:text=Depuis%20le%201er%20janvier,r%C3%A9ception%20de%20la%20facture%20finale.

JulienAlardot · 2023-10-30T12:20:29Z

@tsb-odoo So? We want this fix and rework that case on the side or we don't want this fix and rework that case on the side?
@robinengels @caburj Do you know anything about that case that could answer tsb questions?

robinengels · 2023-11-03T10:45:29Z

@tsb-odoo ping

robinengels · 2023-11-14T10:50:15Z

@tsb-odoo @JulienAlardot ping

robinengels · 2023-11-20T10:26:56Z

@tsb-odoo @JulienAlardot @caburj ping

robinengels · 2023-11-28T10:42:09Z

@tsb-odoo @JulienAlardot @caburj ping

caburj

I'm okay with this patch unless @tsb-odoo really thinks this is a mistake.

caburj · 2023-12-01T12:38:56Z

addons/l10n_be_pos_sale/static/src/js/PaymentScreen.js

+
+export const PoSSaleBePaymentScreen = (PaymentScreen) =>
+    class extends PaymentScreen {
+        async toggleIsToInvoice() {


Suggested change

async toggleIsToInvoice() {

toggleIsToInvoice() {

Don't change the "color" of the function, we should keep it synchronous.

caburj · 2023-12-01T12:39:34Z

addons/l10n_be_pos_sale/static/src/js/PaymentScreen.js

+        async toggleIsToInvoice() {
+            const has_origin_order = this.currentOrder.get_orderlines().some(line => line.sale_order_origin_id);
+            if(this.currentOrder.is_to_invoice() && this.env.pos.company.country.code === "BE" && has_origin_order){
+                await this.showPopup('ErrorPopup', {


Suggested change

await this.showPopup('ErrorPopup', {

this.showPopup('ErrorPopup', {

caburj · 2023-12-01T12:40:40Z

addons/l10n_be_pos_sale/static/src/js/ProductScreen.js

+        setup() {
+            super.setup();
+        }


You can remove this since you're not adding anything in the setup logic.

addons/l10n_be_pos_sale/static/tests/tours/l10n_be_pos_sale_tour.js

robinengels · 2023-12-15T12:40:28Z

@caburj You might need to R+ this one again

caburj · 2023-12-15T13:18:03Z

robodoo r+

robodoo · 2023-12-15T14:38:50Z

@robinengels @caburj staging failed: ci/runbot on 5699906808539f79c7c9d670b39ab68c63d1dca9 (view more at https://runbot.odoo.com/runbot/build/55176288)

Current behavior: ?In Belgium? when using a EU intracom tax, as we need to report those special sales to the government we need to create an invoice as we need to report the customer name, VAT number and the country where the goods are going to end up Steps to reproduce: - Create an order with a product and a tax (0% EU M) - Settle the order in the PoS and pay it (no invoice) - Go to the accounting and check the EC Sales List report - There is an error shown in the report opw-3514737

caburj · 2023-12-20T15:12:04Z

robodoo r+

Current behavior: ?In Belgium? when using a EU intracom tax, as we need to report those special sales to the government we need to create an invoice as we need to report the customer name, VAT number and the country where the goods are going to end up Steps to reproduce: - Create an order with a product and a tax (0% EU M) - Settle the order in the PoS and pay it (no invoice) - Go to the accounting and check the EC Sales List report - There is an error shown in the report opw-3514737 closes #139467 Signed-off-by: Joseph Caburnay (jcb) <[email protected]>

fw-bot · 2023-12-24T05:54:06Z