Move color issues to main section

[jamesnw]

Description

The Color Issues section is getting long, especially with #222. This moves the content to the main section, underneath the colors.

Steps to test/reproduce

The section should be collapsed on small screens by default, and expanded on large screens.

https://deploy-preview-223--oddcontrast.netlify.app/

Todo

• Probably needs some margins or something

[netlify]

✅ Deploy Preview for oddcontrast ready!

Name	Link
🔨 Latest commit	7eae78d
🔍 Latest deploy log	https://app.netlify.com/sites/oddcontrast/deploys/67a213dba4802d00082ba943
😎 Deploy Preview	https://deploy-preview-223--oddcontrast.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[dvdherron]

@SondraE @stacyk

I think this is ready for a review. I just added some spacing around the Known Issues section now that it's at the end of the main content section. And put the open triangle for the section in front of "Known Issues."

Are we okay with keeping the same colors here or do we want to make this section look different?

Played around with the width of the text. Open to adjusting as needed.

[stacyk]

Part of me wonders if we need to collapse this info since we are moving it to the main content area. The designer part of me thinks this whole page is getting crowded though and I want to collapse it or move it to a blog post.

Regardless, I don't think we need it in the colors selected, what about you @SondraE?

The known issues box does grow if I am on my second monitor which is taller than my laptop viewport.

[SondraE]

@dvdherron @stacyk
I agree that we don't need to keep this content in the colors selected.

I wonder about a layout design like this. Even though it's still on the same page, this is styled more like a blog post. If there are any demo images that would be useful to add into this Known Color Issues section, they could be more easily included into a layout like this.

[jamesnw]

@dvdherron @stacyk I agree that we don't need to keep this content in the colors selected.

I wonder about a layout design like this. Even though it's still on the same page, this is styled more like a blog post. If there are any demo images that would be useful to add into this Known Color Issues section, they could be more easily included into a layout like this.

This also would make it easier to link to one of the sections, as was proposed in #222.

[dvdherron]

I wonder about a layout design like this. Even though it's still on the same page, this is styled more like a blog post. If there are any demo images that would be useful to add into this Known Color Issues section, they could be more easily included into a layout like this.

Ok, so we would change this into a section on the page with a list of issues instead of the current disclosure element? Sounds good to me. And I agree it makes sense that this section's colors don't have to match the selected colors.

[dvdherron]

I agree that we don't need to keep this content in the colors selected.

I wonder about a layout design like this. Even though it's still on the same page, this is styled more like a blog post. If there are any demo images that would be useful to add into this Known Color Issues section, they could be more easily included into a layout like this.

@stacyk @SondraE Applied these changes in 16ee6fd and 1e6c290. Let me know what you think!

[stacyk]

Left a question. I'm approving as the questions may not change anything, but there is one reordering suggestion as well. :)

[dvdherron]

@stacyk Addressed your questions/comments above. This is ready for another review.

[stacyk]

👍🏻