Fake dune-project file
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I have tried copying all the |
shonfeder
approved these changes
Dec 6, 2024
This was referenced Dec 12, 2024
Closed
mtelvers
added a commit
that referenced
this pull request
Jan 7, 2025
Revert PR #993 now Dune 3.17.1 has been released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #990 and #991
This PR creates a minimal
dune-projectfile which is good enough fordune substnot to fail.An empty file is not good enough. It must have at least the
langstanza. However, whichlangversion should be specified as potentially, if a project specifically requests dune version 2, then this hack won't work.