-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): use OpenAPI spec #841
Conversation
Some errors: Error: test/typescript-validate.ts(106,7): error TS2578: Unused '@ts-expect-error' directive. Also some from the types.d.ts about the property "webhook-check-run-created-form-encoded" not existing on a type |
I am aware of the errors.
This is due to github/rest-api-description#2465
That has been fixed. octokit/openapi-webhooks@01457e3 I haven't updated this PR |
Great |
The webhooks OpenAPI spec has been out for a year now. The schemas (excluding enum values) are pretty much the same. I have noticed in many areas where they don't change the Overall it would be nice to have people test this package with the OpenAPI webhooks spec |
Use `node:` specifier imports, use full relative path imports Fix usage of Prettier for v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked through the changes and it looks great, thank you for putting in all this work! When we ship it, shall we move @wolfy1339/openapi-webhooks-types and @wolfy1339/openapi-webhooks to @octokit as well?
Yes, that was the goal |
I am coming around to this PR again, I have created octokit/openapi-webhooks#80 to track the move to the Octokit org. I don't have the permissions to move the repo myself, so whomever is available that can do it @kfcampbell @gr2m @nickfloyd |
🎉 This PR is included in version 12.2.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #840
Behavior
Before the change?
After the change?
Other information
Additional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Feature