-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump @octokit/webhooks-methods
to ^2.0.0
#587
Conversation
@octokit/webhooks-methods
to ^2.0.0
'@octokit/webhooks-methods
to ^2.0.0
🎉 This PR is included in version 9.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@wolfy1339 This is a breaking change, and led to all my GitHub payloads breaking. This is because |
for context, I am using Express, and had this middleware: app.use((req, res, next) => {
if (req.originalUrl.includes('/stripe/webhook')) {
bodyParser.raw({ type: 'application/json' })(req, res, next);
} else {
bodyParser.json()(req, res, next);
}
}); However, with this PR, I had to change it to app.use((req, res, next) => {
if (req.originalUrl.includes('/stripe/webhook')) {
bodyParser.raw({ type: 'application/json' })(req, res, next);
} else if (req.originalUrl.includes('/webhooks/github')) {
bodyParser.text({ type: 'application/json' })(req, res, next);
} else {
bodyParser.json()(req, res, next);
}
}); |
It was a breaking change in the |
@wolfy1339 Ya I saw the changes, but the compatibility layer didn't seem to have any effect |
Could you open a new issue with all the details, and we can start looking from there |
sure, will do |
follow up to octokit/webhooks-methods.js#21