Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): .onAny() event.name #443

Closed
wants to merge 1 commit into from
Closed

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Feb 4, 2021

Like #435, the .onAny() event.name is e.g. "check_run", vs. "*"

hooksCalled.push(`* (${event.name})`);


Thanks for #435!

@wolfy1339 wolfy1339 requested a review from G-Rath February 5, 2021 00:46
@wolfy1339 wolfy1339 added Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only labels Feb 5, 2021
Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gr2m I'm thinking it might be a good time to just cut a new major release, dropping the old types and the error & * events as that'd let us do some good simplification to the types and make things less confusing (at least for me 😅)

@gr2m
Copy link
Contributor

gr2m commented Feb 5, 2021

@gr2m I'm thinking it might be a good time to just cut a new major release, dropping the old types and the error & * events as that'd let us do some good simplification to the types and make things less confusing (at least for me 😅)

Yes, agreed

Copy link
Member

@G-Rath G-Rath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to get started on a next branch, which'll likely include this change so going to hold off merging it for now.

@G-Rath G-Rath mentioned this pull request Feb 5, 2021
@jablko jablko changed the title fix(types): .onAny() even.name fix(types): .onAny() event.name Feb 5, 2021
@gr2m gr2m closed this in #444 Feb 8, 2021
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 8.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented, or is being fixed typescript Relevant to TypeScript users only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants