Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release.yml by only running for octokit owner #614

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 18, 2024

Resolves #613


Before the change?

  • release.yml fails on forks

After the change?

  • release.yml won't fail on forks

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Copy link
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 24, 2024
@nickfloyd
Copy link
Contributor

nickfloyd commented Dec 26, 2024

Hey @jsoref Apologies for the delay on getting back to you on this. Unfortunately this one got lost in the shuffle.

Looking at this now, it's clear that you are wanting to release from a fork but I was wondering what use case this was fulfilling from a community standpoint. We release this using the semantic release package which assumes a few things - just trying to get an idea of what were you looking to do with releasing from a fork outside of the scope of a normal release.

Let us know if you get a chance. Thanks!

@jsoref
Copy link
Contributor Author

jsoref commented Dec 26, 2024

@nickfloyd:
I'm not trying to release, i'm trying not to get an ❌ when I sync my fork.

I'd be perfectly happy with adding a constraint of if: github.owner == 'octokit' if you'd prefer.

@nickfloyd
Copy link
Contributor

@nickfloyd: I'm not trying to release, i'm trying not to get an ❌ when I sync my fork.

Thank you for the clarity! That completely makes sense.

I'd be perfectly happy with adding a constraint of if: github.owner == 'octokit' if you'd prefer.

We'd definitely prefer that approach if you have time to make the change.

@jsoref jsoref changed the title Fix release.yml by looking before leaping Fix release.yml by only running for octokit owner Dec 27, 2024
@nickfloyd nickfloyd merged commit 2068a22 into octokit:main Jan 2, 2025
4 checks passed
@jsoref jsoref deleted the isue-613 branch January 2, 2025 16:13
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 13.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Release needs guards
4 participants