-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: v21 fails eslint-plugin-import
's no-unresolved
rule
#446
Comments
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
i've encountered this in a few other octokit packages as well. if updating this would be accepted, i'd be happy to help out. would it be helpful to open similar issues for the other packages i've seen this in? i'm happy to open PRs as well, but would like confirmation that the contribution is a desired change. if PRs for this are desired, is a PR enough or should I start with issues? |
I've encountered this too |
This adds the `main` property for backwards-compatibility, needed e.g. when running ESLint. The change recapitulates what octokit@aad55f4 already did but which was unfortunately reverted in the same PR by octokit@1b6e582 (probably under the incorrect assumption that `exports.default` would be enough as a fall-back). This fixes octokit#446. Signed-off-by: Johannes Schindelin <[email protected]>
What happened?
the
main
property has been removed, resulting in eslint failures for theimport/no-unresolved
. unfortunately, even though an exports map should cover everything needed, this plugin is unable to understand the exports map. see import-js/eslint-plugin-import#1810 for full info.would you mind including the
main
property and pointing it at the same file as the exports map for backward compatibility?Versions
@octokit/rest
v21.0.0Relevant log output
Code of Conduct
The text was updated successfully, but these errors were encountered: