Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove redirect option #612

Merged
merged 2 commits into from
Jul 9, 2023
Merged

fix(types): remove redirect option #612

merged 2 commits into from
Jul 9, 2023

Conversation

wolfy1339
Copy link
Member

Resolves #611


Behavior

Before the change?

  • The redirect option was defined in the types, but wasn't passed through in the options

After the change?

  • The redirect option is properly passed through to fetch

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jul 9, 2023
src/fetch-wrapper.ts Outdated Show resolved Hide resolved
@wolfy1339 wolfy1339 changed the title fix: pass through redirect option fix(types): remove redirect option Jul 9, 2023
@wolfy1339 wolfy1339 merged commit 724699d into main Jul 9, 2023
@wolfy1339 wolfy1339 deleted the fix-redirect branch July 9, 2023 20:51
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

🎉 This PR is included in version 8.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Bug Something isn't working as documented
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: redirect option not passed through
2 participants