Lwt_react: no longer compare structurally the inputs of S.l[2-6]_s #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a failure when some inputs cannot be compared structurally (if they contain functional values, for instance). Internally, Lwt_react.S.l2 is implemented using React.S.l2 and Lwt_react.S.map_s. We were not providing an equality function to React.S.l2, so the default structural equality was used. Now, we use the function (fun _ _ -> false). So, the function parameter is applied each time any of the input change, which is exactly what we would expect if we implemented Lwt_react.S.map_s directly.
vouillon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a failure when some inputs cannot be compared (if they contain functional values, for instance).
We need to do something anyway if one of the inputs changes, so it makes sense to use physical equality here.