Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lwt_unix.lstat calling Unix.stat on Win32 #883

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Fix Lwt_unix.lstat calling Unix.stat on Win32 #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

* Support IPv6 socketpair on Windows (#870, #876, Antonin Décimo, David Allsopp).

* Lwt_unix.lstat was incorrectly calling Unix.stat on Win32. Fixes
the behavior of Lwt_io.with_temp_dir following symlinks to
directories on Win32. (#883, Antonin Décimo)

====== Additions ======

* Lwt_seq: a Seq-like data-structure with Lwt delayed nodes (#836, #842, Zach Shipko).
Expand Down
2 changes: 1 addition & 1 deletion src/unix/lwt_unix.cppo.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ external lstat_job : string -> Unix.stats job = "lwt_unix_lstat_job"

let lstat name =
if Sys.win32 then
Lwt.return (Unix.stat name)
Lwt.return (Unix.lstat name)
else
run_job (lstat_job name)

Expand Down