Lwt.pick and Lwt.choose pick preferentially failed promises #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smorimoto
force-pushed
the
pick-should-preferentially-fail-as-per-documentation
branch
from
7c5b453 to
c2f77f8
Compare
raphael-proust
force-pushed
the
pick-should-preferentially-fail-as-per-documentation
branch
from
cb7389d to
1fcc916
Compare
smorimoto
approved these changes
Dec 20, 2021
smorimoto
force-pushed
the
pick-should-preferentially-fail-as-per-documentation
branch
from
1fcc916 to
2dad87d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #856 (check for details)
Note that the pick/choose tests were checking for the actual behaviour rather than the documented behaviour. This MR also adapts the tests.