Reduce the number of system calls for accept #769
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
accept4
instead ofaccept
to avoid 2fcntl
system callsaccept4
takes flags to tell to create the file descriptor in non blocking mode. This way we don't need to set it later withUnix.set_nonblock.
Also, since we know that all the calls to accept will be on non blocking sockets we can avoid releasing the runtime lock.