-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove camlp4 reference from the manual #457
Conversation
There is still one reference left of camlp4 in The logging facility section. I'm not sure what to do with it, should I just delete it altogether? |
Probably the best is to replace it by some kind of summary of, or reference to, the PPX logging support section https://ocsigen.org/lwt/3.0.0/api/Ppx_lwt#2_Logging. |
It looks good. The only thing I'd recommend is adding an example of a command line for triggering the PPX, i.e. with |
And don't worry about the 4.06+trunk build failure – that's clearly an upstream problem. I'll move it to |
(And if you'd like to see more details on that upstream issue, ocaml-ppx/ocaml-migrate-parsetree#19 (comment)). |
I've updated the PR with the example to use Sorry for the late commits, timezone issues 🙂 |
Looks good. Thanks! |
Checked the generated version online (it's hard to do so ahead of time). It looks good as well. |
That's good to hear, and thanks for letting me take this! |
Solves #449.
Removes camlp4 reference, since its use has been deprecated. The "Correspondence table" is also updated to use the Ppx syntax.