Skip to content

Commit

Permalink
Release 4.5.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@aantron
aantron committed Dec 15, 2019
1 parent 1a019a9 commit 768feed
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion lwt.opam
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ opam-version: "2.0"

synopsis: "Promises and event-driven I/O"

version: "dev"
version: "4.5.0"
license: "MIT"
homepage: "https://github.com/ocsigen/lwt"
doc: "https://ocsigen.org/lwt/manual/"
Expand Down
1 change: 0 additions & 1 deletion src/core/dune
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@
(public_name lwt)
(synopsis "Monadic promises and concurrent I/O")
(wrapped false)
(preprocess (pps bisect_ppx --conditional))
(libraries bytes result seq)
(flags (:standard -w +A-29)))
1 change: 0 additions & 1 deletion src/unix/dune
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
(optional)
(wrapped false)
(libraries bigarray lwt mmap ocplib-endian.bigstring threads unix)
(preprocess (pps bisect_ppx --conditional))
(c_names
lwt_unix_stubs
lwt_libev_stubs
Expand Down

4 comments on commit 768feed

@olafhering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this release commit is incomplete, ppx and react fail:

[   72s] File "src/ppx/dune", line 9, characters 51-61:
[   72s] 9 |  (preprocess (pps ppx_tools_versioned.metaquot_409 bisect_ppx --conditional))
[   72s]                                                        ^^^^^^^^^^
[   72s] Error: Library "bisect_ppx" not found.
[   72s] Hint: try: dune external-lib-deps --missing --for-release-of-packages
[   72s]   lwt,lwt_ppx,lwt_react -j 6 --verbose @install
[   72s] File "src/react/dune", line 13, characters 18-28:
[   73s] 13 |  (preprocess (pps bisect_ppx --conditional))
[   73s]                        ^^^^^^^^^^
[   73s] Error: Library "bisect_ppx" not found.
[   73s] Hint: try: dune external-lib-deps --missing --for-release-of-packages
[   73s]   lwt,lwt_ppx,lwt_react -j 6 --verbose @install

@aantron
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a release of package lwt only, packages lwt_ppx and lwt_react were not released here. In the normal opam build process, the package being released is built with dune build -p lwt, which will cause Dune to ignore the rest of the packages (and thus their dependencies). Is this an issue for your build or packaging processes?

@olafhering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I did not know that. I use -p lwt,lwt_ppx,lwt_react. At least my build used to work with 4.4.0.

If I remove lines with bisect_ppx:

[   27s] File "src/ppx/ppx_lwt.ml", line 33, characters 27-30:
[   27s] Error: Uninterpreted extension 'pat'.

I'm fine with keeping the existing 4.4.0 release.

@aantron
Copy link
Collaborator Author

@aantron aantron commented on 768feed Dec 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pat error is because you should remove only bisect_ppx --conditional from the line in src/ppx/dune that contains bisect_ppx. The other PPXs mentioned on that line should remain.

An easy way to tell what was released in repos I do releases in is to look at the title of each release (see https://github.com/ocsigen/lwt/releases).

Please sign in to comment.