-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ci mac #1744
Fix ci mac #1744
Conversation
I suspect we can just remove this code now. |
What makes you say that ? |
This seems to work for this PR: ocaml-wasm/wasm_of_ocaml#131 (ocaml-wasm/wasm_of_ocaml@4ee156e). From what I understand, the latest macos runner image installs pkgconfig, which breaks the conf-pkg-config opam packages. So now, conf-pkg-config installs pkgconfig instead. This broke the CIs still using the previous runner image. |
Are you sure this is not working just because of caches ? |
That's what I meant. You can probably just remove the previous fix. This job is failing without the initial fix: https://github.com/ocsigen/js_of_ocaml/actions/runs/11916809033/job/33210339357 The initial fix no longer work for this job: https://github.com/ocsigen/js_of_ocaml/actions/runs/12012253626/job/33483052722 And this jobs was already using the newer image, at a much earlier date: https://github.com/coq/platform/actions/runs/11838273102/job/32987032575 |
No description provided.