Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isSpaceChar overflow on 32-bit arches #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix isSpaceChar overflow on 32-bit arches #68

wants to merge 2 commits into from

Conversation

swt2c
Copy link

@swt2c swt2c commented Apr 1, 2025

Fixes: #67

@ocramz
Copy link
Owner

ocramz commented Apr 1, 2025

@swt2c Thank you! Could you please address #69 as well in this branch, see whether CI turns green?

@swt2c
Copy link
Author

swt2c commented Apr 1, 2025

@ocramz working on it!

@swt2c swt2c force-pushed the fix_32_bit branch 3 times, most recently from bfb56a7 to 7436ad5 Compare April 1, 2025 15:32
@swt2c
Copy link
Author

swt2c commented Apr 1, 2025

@ocramz CI should now be fixed with my second commit. Note that it just gets the (relatively old) existing stack versions going again. There are other issues when getting it to work on current versions, see #70.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failures on 32-bit architectures
2 participants
@swt2c @ocramz