Backends: OSX: Remove notification observer when shutting down #8331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
pushed a commit
that referenced
this pull request
Jan 20, 2025
|
Thank you for your PR! Merged as aa1b4ea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the ImGui observer from NSNotificationCenter when shutting down.
Explanation:
This prevents an issue that may occur when shutting down, where ImGui receives a
NSApplicationDidResignActiveNotificationfrom the notification center. When this happens, ImGui will callImGui::GetIO()but this call will trigger an assert as the context has already been destroyed, causing the application to crash.