Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ImeSetInputScreenPosFn to pass the line_height. #3113

Closed
wants to merge 1 commit into from
Closed

Update ImeSetInputScreenPosFn to pass the line_height. #3113

wants to merge 1 commit into from

Conversation

liuliu
Copy link
Contributor

@liuliu liuliu commented Apr 9, 2020 •
edited
Loading

This PR is to continue the discussion in #3108 (comment)

As of now, I only cherry-picked the commit into this PR. I think changing
it from Vec2 to Vec4 would be nicer, but we need to have a good definition
of what that rectangle is (the cursor shape? the next char? the existing chars
with proposed text (markedText)?).

I don't have a Windows to continue the discussion on changing the
defaultImpl to use poll. I think it would be interesting to do that, and is
probably the right change, but don't have full context yet.

@liuliu
Copy link
Contributor Author

liuliu commented Jun 9, 2020

Hi, @ocornut, what's your thought on this PR so far? Thanks!

@ocornut
Copy link
Owner

ocornut commented Jun 10, 2020

Hello @liuliu, apologies, I will look at this and #3108 when possible but it may take a while. Please keep the issues open as I'd like to get this solved. Thank you for your patience.

@liuliu
Copy link
Contributor Author

liuliu commented Jun 10, 2020

Thank you! No worries!

@ocornut ocornut added the ime label Dec 14, 2020
@ocornut ocornut force-pushed the master branch 2 times, most recently from 0c1e5bd to bb6a60b Compare August 27, 2021 19:10
@ocornut ocornut force-pushed the master branch 2 times, most recently from 8b83e0a to d735066 Compare December 13, 2021 11:31
ocornut added a commit that referenced this pull request Jan 5, 2022
@ocornut
Platform IME: changed io.ImeSetInputScreenPosFn() to io.SetPlatformIm…
3a90dc3 
…eDataFn() API.

Ref #2589, #2598, #3108, #3113, #3653, #4642
ocornut pushed a commit that referenced this pull request Jan 5, 2022
@liuliu @ocornut
Platform IME: add ImGuiPlatformImeData::InputLineHeight (unused by wi…
de36ff0 
…n32). (#3113)
ocornut added a commit that referenced this pull request Jan 5, 2022
@ocornut
Merge branch 'master' into docking. Remove Platform_SetImeInputPos. R…
704ab11 
…emove backend-side IME implementation. Rrevert removal of MouseDragMaxDistanceAbs in 206b9ea. (#2589, #3113)

# Conflicts:
#	backends/imgui_impl_glfw.cpp
#	backends/imgui_impl_sdl.cpp
#	backends/imgui_impl_win32.cpp
#	imgui.cpp
#	imgui.h
#	imgui_internal.h
#	imgui_widgets.cpp
@ocornut
Copy link
Owner

ocornut commented Jan 5, 2022

Hello @liuliu ,
I've done some work today on standardizing IME api (previously it was different in master vs docking)
And included your change as part of the work.

The commits are
3a90dc3
2706c9d
1cbfe93 call ImmSetCandidateWindow() to position candidate window.
29a8ee0 add visible flag (#2589)
de36ff0 add line height (#3113) <- your feature, yet unused

Thank you for your patience!

I think this will break #3108 but the changes/API are more reasonable now.
If you have the time to rework #3108 that would be nice (only changes in the backends should be required now)

@ocornut ocornut closed this Jan 5, 2022
@ocornut ocornut mentioned this pull request Jan 5, 2022
Closed
ocornut added a commit that referenced this pull request Jan 15, 2024
@ocornut
Commented out obsolete ImGuiIO::ImeWindowHandle marked obsolete in 1.…
8a3dfda 
…87, favor of writing to 'void* ImGuiViewport::PlatformHandleRaw'.

Amend 3a90dc3 (#2589, #2598, #3108, #3113, #3653, #4642)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backends ime inputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuliu @ocornut