SetWindowFontScale doesn't inherit parent scale for full chain of parent windows

[vegorovinno]

Version: 1.72
Branch: master v1.72 tag

Back-ends: custom
Compiler: Visual Studio 2019
Operating System: Windows 10

My Issue/Question:

Recent 1.72 update made a change to window font scale: Fixed old SetWindowFontScale() api value from not being inherited by child window. Added comments about the right way to scale your UI

But the value is only being inherited from an immediate parent (not the whole window set up to the root).

Screenshots/Video

Image

ImGui::Begin("Issue");

	ImGui::SetWindowFontScale(1.0f);

	ImGui::Text("TEXT 1");

	{
		ImGui::BeginChild("Issue - Part 2");

		ImGui::SetWindowFontScale(2.0f);

		ImGui::Text("TEXT 2");

		{
			ImGui::BeginChild("Issue - Part 3");

			ImGui::Text("TEXT 3");

			{
				ImGui::BeginChild("Issue - Part 4");

				ImGui::Text("TEXT 4");

				ImGui::End();
			}

			ImGui::End();
		}

		ImGui::End();
	}

	ImGui::End();

"TEXT 4" doesn't inherit 2x scale from "Part 2" child.

[ocornut]

I'll look into fixing this, thank you.
Are you actually using this old function, or did you only found about it because recent changelog?

Attachment:

[vegorovinno]

We were using it since April so at first we thought that now we can remove this call after each ImGui::BeginChild.

[n00bmind]

My 2 cents on this..
We are using this function, our app has a main scalable canvas where we want to vary the font size, and child panel windows where we want it to stay constant, so for us it'd be good to be able to disable the scaling applied from the parent..
Any chance of having a flag passed to the function to control this behaviour?

Thanks!

[ocornut]

This is now fixed by b7c27c5.
Note that an upcoming major release should make this obsolete as we will introduce better font scaling functions, but in the meanwhile it works better now.