Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Help Templates not being used in the help command #377

Closed
oscb opened this issue Mar 15, 2022 · 0 comments · Fixed by #523
Closed

Custom Help Templates not being used in the help command #377

oscb opened this issue Mar 15, 2022 · 0 comments · Fixed by #523

Comments

@oscb
Copy link

oscb commented Mar 15, 2022 •
edited
Loading

When setting up a helpClass in the oclif config in package.json the Help command does not use the provided class and defaults always to the oclif implementation.

Seems to be related to removing the getHelpClass in the command, I think it should be using the loadHelpClass from oclif/core to figure out what HelpClass it should use: https://github.com/oclif/plugin-help/blame/095b4b4950ee442c423499ed8ea5e60572216322/src/commands/help.ts#L20
scott-rc added a commit to gadget-inc/ggt that referenced this issue Aug 15, 2022
@scott-rc
Replace @oclif/plugin-help with own implementation
613c817 
@oclif/plugin-help doesn't use custom help templates so
`ggt sync --help` produces different output compared to
`ggt help sync`. This fixes that.

There's an open issue for this here:

oclif/plugin-help#377
@jneidel jneidel mentioned this issue Apr 6, 2023
Closed
@DanHulton DanHulton mentioned this issue Jul 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support custom help classes. DanHulton/plugin-help
Support custom help classes
1 participant
@oscb