refactor: cleanup flags

[MunifTanjim]

• Remove unused types mentioned in [QUESTION] Is flag.completion type used anywhere? #92
• Remove duplicate codes that are already present in @oclif/parser - flags.ts
• Remove optionType from flags.enum (optionType was removed from @oclif/parser back in Feb, 2018: oclif/parser@15bb0d0)

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @MunifTanjim to sign the Salesforce.com Contributor License Agreement.

[codecov]

Codecov Report

Merging #93 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master     #93   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          10      10           
  Branches        2       2           
======================================
  Misses         10      10           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492cadb...7b8b7c5. Read the comment docs.

[RasPhilCo]

Thanks for the PR! Good catch on removing optionType, however autocomplete needs the types deleted and those flag builders are exported (requiring a deprecation notice or major bump). Let's start with removing optionType in its own PR and go from there on larger refactor.

[MunifTanjim]

👍 @RasPhilCo Done!

Let's start with removing optionType in its own PR and go from there on larger refactor.

Can we move these codes (along with the completion types) from command/src/flags.ts to parser/src/flags.ts next? And then we can just import them from parser package and re-export them from the command package.

Edit: I see that IConfig is not available in parser package. So, that probably won't happen.

[RasPhilCo]

🏄