Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispenser tests #514

Merged
merged 8 commits into from
Aug 12, 2022
Merged

Dispenser tests #514

merged 8 commits into from
Aug 12, 2022

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Aug 11, 2022 •
edited
Loading

Fixes #193
Fixes: #515

Changes proposed in this PR:

  • Fixing handleDeactivate dispenser
  • Dispenser tests:
    • initialize Dispenser and datatoken class
    • Deploying an NFT with ERC20
    • Test all DT Fields after deploying
    • Make user1 minter
    • Create dispenser
    • Deactivates dispenser
    • Activates exchange
    • User2 gets datatokens from the dispenser
    • Owner withdraws all of the datatokens
    • Updates allowed swapper

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review August 11, 2022 12:58
@mihaisc mihaisc self-requested a review August 11, 2022 13:44
mihaisc
mihaisc approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@mihaisc mihaisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflict

@jamiehewitt15
Copy link
Member Author

fix conflict

Done

@jamiehewitt15 jamiehewitt15 merged commit 02e980f into main Aug 12, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-193-dispenser-tests branch August 12, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix handleDeactivate in dispenser Testing: DIspenser
2 participants
@jamiehewitt15 @mihaisc