Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tests for NFT and Datatokens #498

Merged
merged 15 commits into from
Aug 2, 2022
Merged

Additional tests for NFT and Datatokens #498

merged 15 commits into from
Aug 2, 2022

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented Jul 25, 2022 •
edited
Loading

Closes: #190
Closes: #191

Changes proposed in this PR:

  • Testing all fields NFTs
  • Testing all fields datatokens
  • Testing orders and orderCount are correctly updated in datatokens
  • Testing all NFT and datatoken fields before and after updating metadata
  • Todo: check balances, dependant on: tokenBalancesOwned isn't updated #500

@mihaisc
Copy link
Contributor

mihaisc commented Jul 25, 2022

Merge main please, graph-cli version increment seems important for tests.

@mihaisc
Copy link
Contributor

mihaisc commented Aug 1, 2022

Can you check please why those 2 tests fail

@jamiehewitt15
Copy link
Member Author

Working now

@jamiehewitt15 jamiehewitt15 mentioned this pull request Aug 2, 2022
Merged
@mihaisc mihaisc self-requested a review August 2, 2022 08:06
@mihaisc mihaisc merged commit bd03b28 into main Aug 2, 2022
@mihaisc mihaisc deleted the issue-190-tests-datatoken branch August 2, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testing: Metadata Tests: Datatokens
2 participants
@jamiehewitt15 @mihaisc