Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changing the type of lastPriceToken from string to Token on Order #462

Merged
merged 2 commits into from
Jun 27, 2022
Merged

changing the type of lastPriceToken from string to Token on Order #462

merged 2 commits into from
Jun 27, 2022

Conversation

jamiehewitt15
Copy link
Member

Fixes #447

Changes proposed in this PR:

  • changing the type of lastPriceToken from string to Token on Order

@jamiehewitt15 jamiehewitt15 marked this pull request as draft June 20, 2022 12:33
@mihaisc mihaisc mentioned this pull request Jun 22, 2022
Closed
@mihaisc
Copy link
Contributor

mihaisc commented Jun 24, 2022

is there anything more here to do?

@jamiehewitt15
Copy link
Member Author

is there anything more here to do?

I was thinking about adding a test but it can also be reviewed as it is

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review June 24, 2022 12:45
@mihaisc mihaisc self-requested a review June 24, 2022 14:16
@jamiehewitt15 jamiehewitt15 merged commit bc693e7 into main Jun 27, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-447-lastPriceTOken branch June 27, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaisc mihaisc mihaisc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change type of lastPriceToken from string to Token
2 participants
@jamiehewitt15 @mihaisc