Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking transfer event & updating nft owner #436

Merged
merged 21 commits into from
Jun 24, 2022

Conversation

jamiehewitt15
Copy link
Member

@jamiehewitt15 jamiehewitt15 commented May 16, 2022

Fixes #404

Changes proposed in this PR:

  • Tracking the Transfer event
  • Writing a test to check if it works or not

@jamiehewitt15 jamiehewitt15 marked this pull request as ready for review June 22, 2022 14:39
@jamiehewitt15 jamiehewitt15 requested a review from mihaisc June 22, 2022 14:39
)
const erc721Address = result.events.NFTCreated.returnValues[0]
const datatokenAddress = result.events.TokenCreated.returnValues[0]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a subgraph query here (same as below), to make sure we get the right owner after create and before transfer ?

Copy link
Member Author

@jamiehewitt15 jamiehewitt15 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sure

@jamiehewitt15 jamiehewitt15 merged commit 603a25f into main Jun 24, 2022
@jamiehewitt15 jamiehewitt15 deleted the issue-404-updating-nft-owner branch June 24, 2022 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nft owner not updating after transfer
2 participants